Wireshark-commits: [Wireshark-commits] master 439005c: rlcmac: Introduce MS Radio Access Capabiliti
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 25 Mar 2020 20:16:58 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=439005cc2c78258d47a85e4b161df9c37041e60a
Submitter: "Pascal Quantin <pascal@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

439005c by Pau Espin Pedrol (pespin@xxxxxxxxxxx):

    rlcmac: Introduce MS Radio Access Capabilities 2 to fix related spare bits
    
    There's two variants for the Ms Radio Access Capabilities.
    * The usual encoding with spare bits (usually to fill up to octet boundary)
    as defined in TS 24.008 Table 10.5.146
    And there's too:
    * MS Radio Access Capabilities 2 IE from TS44.060 section 12.30, which is
    the same but removing all spare bits, and which is used in messages like
    Packet Resource Request and Additional MS RAC messages.
    
    The later is used basically for messages having extra IEs after the MS
    Radio Access capabilities IE, since they are encoded immediatelly
    afterwards.
    
    So this patch does:
    * Adds the expected spare bits (M_PADDING) to MS_Radio_Access_capability_t
    * Creates a new MS_Radio_Access_capability2_t without padding
    * Updates code to use the new "2" version where needed.
    
    The new MS_Radio_Access_capability_t with padding is disabled since it's
    not used in wirehsark because it's using an ad-hoc decoder for that TS
    24.008 IE: see packet-gsm_a_gm.c de_gmm_ms_radio_acc_cap()
    
    Port from osmo-pcu.git e50ce6e45c4509805807d599cadf1a1b23d37f63
    Related: https://osmocom.org/issues/4463
    
    Change-Id: Ie2844bd94437c8d7a50787cc7c8c4d81a4fc48ba
    Reviewed-on: https://code.wireshark.org/review/36574
    Petri-Dish: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    

Actions performed:

    from  69a4769   rlcmac: Fix bug receiving RA cap
     add  439005c   rlcmac: Introduce MS Radio Access Capabilities 2 to fix related spare bits


Summary of changes:
 epan/dissectors/packet-gsm_rlcmac.c | 24 +++++++++++++++++-------
 epan/dissectors/packet-gsm_rlcmac.h |  6 +++---
 2 files changed, 20 insertions(+), 10 deletions(-)