Wireshark-commits: [Wireshark-commits] master-3.2 e854276: rlcmac: Fix bug receiving RA cap
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e8542760aa94a4d3becc9e0d7137214cc2be16f3
Submitter: "Pascal Quantin <pascal@xxxxxxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark
Commits:
e854276 by Pau Espin Pedrol (pespin@xxxxxxxxxxx):
rlcmac: Fix bug receiving RA cap
It seems the assumptions regarding maximum number of RA capabilitites
in one message were wrong. Doing some rough calculations, each RA
capabilitiy value (without extensions) can take around 20ish bits, which
means for a message containing up to 52 bytes that quite a lot of
different values could be theoretically fed in. Let's be safe and
increase the array size to be able to handle all different access
technologies listed in See TS 24.008 table 10.5.146 following
restrictions:
* "The MS Radio Access capability is a type 4 information element, with a maximum length of 52 octets."
* "Among the three Access Type Technologies GSM 900-P, GSM 900-E and GSM 900-R only one shall be present."
* "the mobile station should provide the relevant radio access
capability for either GSM 1800 band OR GSM 1900 band, not both".
Port from osmo-pcu.git 7faa5da209d0ef48fe593603c217615f09fb61fb.
Related: https://osmocom.org/issues/4463
Change-Id: Ief5189f88ba0e4970847567c9a15b1ada8b9df4b
Reviewed-on: https://code.wireshark.org/review/36573
Reviewed-by: Harald Welte <laforge@xxxxxxxxxxxx>
Petri-Dish: Pascal Quantin <pascal@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@xxxxxxxxxxxxx>
(cherry picked from commit 69a47691cdf6a9304ef8689d3a39d510e81e001c)
Reviewed-on: https://code.wireshark.org/review/36578
Actions performed:
from 226939b gitlab-ci: upgrade to Clang 10, drop special -Wframe-larger-than case
add e854276 rlcmac: Fix bug receiving RA cap
Summary of changes:
epan/dissectors/packet-gsm_rlcmac.h | 18 +++++-------------
1 file changed, 5 insertions(+), 13 deletions(-)
