Wireshark-commits: [Wireshark-commits] master 3e9ce48: dot11decrypt: Fix decryption of MFP enabled
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 23 Mar 2020 08:46:04 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3e9ce48d24242c891968f65ae5160e967e73cfa5
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

3e9ce48 by Mikael Kanstrup (mikael.kanstrup@xxxxxxxx):

    dot11decrypt: Fix decryption of MFP enabled connections
    
    MFP enabled connections with SHA-256 key management (IEEE 802.11w) use
    EAPOL key version == 3. This case was missing making decryption of such
    connections fail. Allow key version 3 to handle these too.
    
    Change-Id: If9e3fcc5c3bbfb46e82b39dfed5b2a74787a4f16
    Reviewed-on: https://code.wireshark.org/review/36534
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  f998e78   RTCP: contain BYE packet dissection to its stated length
     add  3e9ce48   dot11decrypt: Fix decryption of MFP enabled connections


Summary of changes:
 epan/crypt/dot11decrypt.c            |  19 ++++++++++---------
 test/captures/wpa2-psk-mfp.pcapng.gz | Bin 0 -> 3128 bytes
 test/suite_decryption.py             |  13 +++++++++++++
 3 files changed, 23 insertions(+), 9 deletions(-)
 create mode 100644 test/captures/wpa2-psk-mfp.pcapng.gz