Wireshark · Wireshark-commits: [Wireshark-commits] master-2.6 f5ff525: RTCP: contain BYE packet dissection to its stated length

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f5ff525868c0331b270a4ae7441f2ac64c4ff8aa
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

f5ff525 by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    RTCP: contain BYE packet dissection to its stated length
    
    The Goodbye RTCP packet dissection has to derive whether the optional
    "Reason for leaving" string is present or not. This has to be derived
    from the length. When put into a compound RTCP packet, the length
    derivation from the TVB length does not work, because another RTCP
    packet may follow in this compound RTCP packet.
    
    With this change the stated length of this RTCP packet is passed to
    the RTCP BYE packet dissection function in order to make a proper
    length determination and not overrun into the next RTCP packet in the
    compound RTCP packet.
    
    Bug: 16434
    Change-Id: Iab0fdd52c745028a9928bbef6c731ff649213277
    Reviewed-on: https://code.wireshark.org/review/36532
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit f998e785d5ead49c57ef282765519d4ae75e056e)
    Reviewed-on: https://code.wireshark.org/review/36537
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  e43828a   [Automatic update for 2020-03-22]
     add  f5ff525   RTCP: contain BYE packet dissection to its stated length


Summary of changes:
 epan/dissectors/packet-rtcp.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)