Wireshark-commits: [Wireshark-commits] master 8e76178: Fix reporting of interface-list-fetching err
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 16 Mar 2020 06:51:57 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8e76178fcd9ac415ee8552399ca550ae8e27d8f5
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

8e76178 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix reporting of interface-list-fetching errors.
    
    If the attempt to fetch the list of local interfaces failed, the model
    will be empty, so "model is empty" doesn't imply "no interfaces found".
    First, check whether there was an error, and report the error string;
    otherwise, if the list is empty, report "No interfaces found." (and fix
    the capitalization while we're at it) and, otherwise, return an empty
    string.
    
    Also, if pcap support wasn't configured in at compile time, skip all
    that, and just return a string indicating that.
    
    Change-Id: I498226888272e1bdede2355cc902f8a74b0cce72
    Reviewed-on: https://code.wireshark.org/review/36446
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  eb7774e   Qt: Improve tcptrace graph drag responsiveness
     add  8e76178   Fix reporting of interface-list-fetching errors.


Summary of changes:
 ui/qt/models/interface_tree_model.cpp | 33 +++++++++++++++++++++++++--------
 1 file changed, 25 insertions(+), 8 deletions(-)