Wireshark-commits: [Wireshark-commits] master eb7774e: Qt: Improve tcptrace graph drag responsivene
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 16 Mar 2020 05:05:55 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=eb7774e4c12e636c47049fdb1add80507311d2a2
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

eb7774e by Tomasz Moń (desowin@xxxxxxxxx):

    Qt: Improve tcptrace graph drag responsiveness
    
    Subclass QCPErrorBars with implementation that never accepts clicks.
    This prevents a lot of square root computations in QCustomPlot
    mousePressEvent handle and results in usable tcptrace graph.
    
    An alternative solution to the poor performance problem could be using
    QCP::srmCustom SelectionRectMode. I don't know how to implement graph
    drag with QCP::srmCustom, and thus I went with simple subclass approach.
    
    Bug: 16281
    Change-Id: Id4178e59bdbd2222db4669d0635ff741ebde839f
    Reviewed-on: https://code.wireshark.org/review/36413
    Petri-Dish: Tomasz Moń <desowin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  d87bce7   capture-wpcap: gracefully exit when has_wpcap is false.
     add  eb7774e   Qt: Improve tcptrace graph drag responsiveness


Summary of changes:
 ui/qt/tcp_stream_dialog.cpp | 23 ++++++++++++++++++++---
 ui/qt/tcp_stream_dialog.h   | 12 ++++++++++++
 2 files changed, 32 insertions(+), 3 deletions(-)