Wireshark · Wireshark-commits: [Wireshark-commits] master-3.2 9dab5a5: Fix formatting of the start time and elapsed time.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9dab5a520dff45f4872c4ba5b92abf21103e77be
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

9dab5a5 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix formatting of the start time and elapsed time.
    
    There's no
    
        QString arg(uint a, int fieldWidth = 0, QChar fillChar = QLatin1Char(' '))
            const
    
    version of the arg method of QString, there's only
    
        QString arg(uint a, int fieldWidth = 0, int base = 10,
            QChar fillChar = Latin1Char(' ')) const
    
    so if you don't pass the base argument, it turns the QChar into an int
    (presumably using the unicode method, so that ends up being 0x20 or 32),
    passes it as the base argument (so it does the conversion base-32 -
    that's <= 36, so it's a valid value for the base argument), and defaults
    the fillChar argument to space.
    
    Add 10 as the base argument, so it behaves correctly.
    
    Bug: 16429
    Change-Id: If4872d6d55aa5d9a7489219622d4190827e65d34
    Reviewed-on: https://code.wireshark.org/review/36337
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit f01f5e39720d55a1494388a3f18a15fcd6d9c3d2)
    Reviewed-on: https://code.wireshark.org/review/36338
    

Actions performed:

    from  d5740d4   [Automatic update for 2020-03-08]
     add  9dab5a5   Fix formatting of the start time and elapsed time.


Summary of changes:
 ui/qt/capture_file_dialog.cpp | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)