Wireshark-commits: [Wireshark-commits] master 839209d: Fix formatting of the start time and elapsed
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 08 Mar 2020 19:13:29 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=839209d2198cc06ca768dcb5e428ca6b21974b25
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

839209d by Guy Harris (guy@xxxxxxxxxxxx):

    Fix formatting of the start time and elapsed time.
    
    There's no
    
        QString arg(uint a, int fieldWidth = 0, QChar fillChar = QLatin1Char(' '))
            const
    
    version of the arg method of QString, there's only
    
        QString arg(uint a, int fieldWidth = 0, int base = 10,
            QChar fillChar = Latin1Char(' ')) const
    
    so if you don't pass the base argument, it turns the QChar into an int
    (presumably using the unicode method, so that ends up being 0x20 or 32),
    passes it as the base argument (so it does the conversion base-32 -
    that's <= 36, so it's a valid value for the base argument), and defaults
    the fillChar argument to space.
    
    Add 10 as the base argument, so it behaves correctly.
    
    Bug: 16429
    Change-Id: If4872d6d55aa5d9a7489219622d4190827e65d34
    Reviewed-on: https://code.wireshark.org/review/36337
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  9caf465   Change $HOME to /home in folder documentation example
     add  839209d   Fix formatting of the start time and elapsed time.


Summary of changes:
 ui/qt/capture_file_dialog.cpp | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)