Wireshark · Wireshark-commits: [Wireshark-commits] master 7e2aada: Qt: Connect destroyed() signal to flushAppSignals()

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7e2aada2660c9e8e5a6306021be8a41b9f13dc00
Submitter: "Roland Knall <rknall@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

7e2aada by Tomasz Moń (desowin@xxxxxxxxx):

    Qt: Connect destroyed() signal to flushAppSignals()
    
    Connect destroyed(QWidget *) signal instead of finished(int) to
    flushAppSignals(). This is to ensure that flushAppSignals() is executed
    after any potential accepted() or rejected() slots.
    
    This fixes the code flow for preferences update. That is, the signals are
    first queued in PreferencesDialog::on_buttonBox_accepted() before
    flushAppSignal() is executed.
    
    Change-Id: Ie1497df66adb52cdc10d1b7c701f531d4eeb7351
    Reviewed-on: https://code.wireshark.org/review/34823
    Petri-Dish: Tomasz Moń <desowin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  bc44c7e   TVB(LZ77+Huffman): return proper value on error (CID1451652)
     add  7e2aada   Qt: Connect destroyed() signal to flushAppSignals()


Summary of changes:
 ui/qt/main_window_slots.cpp         | 9 ++++-----
 ui/qt/packet_list.cpp               | 2 +-
 ui/qt/protocol_preferences_menu.cpp | 2 +-
 3 files changed, 6 insertions(+), 7 deletions(-)