Wireshark-commits: [Wireshark-commits] master bc44c7e: TVB(LZ77+Huffman): return proper value on er
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 21 Oct 2019 07:11:46 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bc44c7e0cdd48d836d5499734d8e5392f9a31d35
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

bc44c7e by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    TVB(LZ77+Huffman): return proper value on error (CID1451652)
    
    When preparing to decompress the encoded tree size is the minimum input
    size. When not met the return value (FALSE) would still indicate success,
    being value 0. This could lead to NULL pointer dereference later on.
    Change the return value to -1 to match the function return type.
    
    Change-Id: Ie81d98f55af33518a34bc0b79c29450064886bc3
    Reviewed-on: https://code.wireshark.org/review/34818
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  15a18f3   Qt: Make enum truly anonymous (CID1452175)
     add  bc44c7e   TVB(LZ77+Huffman): return proper value on error (CID1451652)


Summary of changes:
 epan/tvbuff_lz77huff.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)