Wireshark · Wireshark-commits: [Wireshark-commits] master-2.6 26d9d34: wslua: Improve parameter check in ProtoField.new()

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=26d9d343530ce71f5fc6361dbc2e783bd42c55a2
Submitter: "Stig Bjørlykke <stig@xxxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

26d9d34 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    wslua: Improve parameter check in ProtoField.new()
    
    Improve paremeter check in ProtoField.new() when using ftypes.CHAR:
    - Check valid base types and give an error when not supported instead of
      terminate in a g_error() (base.DEC is not supported).
    - Give an error if used with base.UNIT_STRING instead of silently remove
      the flags.
    
    Support using base.NONE with a valuestring.
    Add ftypes.CHAR to the list of supported types.
    
    Change-Id: I0e3f9698074c807f5da0de23ccd1be7446271135
    Reviewed-on: https://code.wireshark.org/review/34783
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 03719942232965069a1fc67d262ab32ab9b7ca2a)
    Reviewed-on: https://code.wireshark.org/review/34791
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  92d31e3   Lua: Use space for indent
     add  26d9d34   wslua: Improve parameter check in ProtoField.new()


Summary of changes:
 epan/wslua/wslua_proto_field.c | 31 +++++++++++++++++++++++--------
 test/lua/protofield.lua        | 21 ++++++++++++++++++++-
 2 files changed, 43 insertions(+), 9 deletions(-)