Wireshark · Wireshark-commits: [Wireshark-commits] master-3.0 cbc94ca: wslua: Improve parameter check in ProtoField.new()

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cbc94caad0709934171715d1e054e7a9ea510427
Submitter: "Stig Bjørlykke <stig@xxxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

cbc94ca by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    wslua: Improve parameter check in ProtoField.new()
    
    Improve paremeter check in ProtoField.new() when using ftypes.CHAR:
    - Check valid base types and give an error when not supported instead of
      terminate in a g_error() (base.DEC is not supported).
    - Give an error if used with base.UNIT_STRING instead of silently remove
      the flags.
    - Support base.RANGE_STRING instead of removing the flag.
    
    Support using base.NONE with a valuestring.
    Add ftypes.CHAR to the list of supported types.
    
    Change-Id: I0e3f9698074c807f5da0de23ccd1be7446271135
    Reviewed-on: https://code.wireshark.org/review/34783
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 03719942232965069a1fc67d262ab32ab9b7ca2a)
    Reviewed-on: https://code.wireshark.org/review/34789
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  a37668e   Lua: Use space for indent
     add  cbc94ca   wslua: Improve parameter check in ProtoField.new()


Summary of changes:
 epan/wslua/wslua_proto_field.c | 34 ++++++++++++++++++++++++----------
 test/lua/protofield.lua        | 21 ++++++++++++++++++++-
 2 files changed, 44 insertions(+), 11 deletions(-)