Wireshark-commits: [Wireshark-commits] master-3.0 2a9e0e2: Qt: Do not turn empty parameter values i
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2a9e0e28624514abd9f841d6c3c0e1249ab3139d
Submitter: "Pascal Quantin <pascal@xxxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark
Commits:
2a9e0e2 by Tomasz Moń (desowin@xxxxxxxxx):
Qt: Do not turn empty parameter values into spaces
Before this change extcap parameters without value would be silently
changed into a single space on parameters load.
This could lead to not only passing unexpected values to extcap call
arguments but also "auto-fill" text values without user consent.
Example scenario to observe this problem using extcap_example.py was:
1. Open "Example interface 1 for extcap" configuration
2. Click Restore Defaults
3. Enter message, so the capture can be started
4. Make sure "Save parameter on capture start" is enabled
5. Start capture
6. Notice that capture starts normally and extcap arguments are ok
7. Stop capture
8. Start capture again
9. Notice that parameters were reloaded and the extcap was called with
following unwanted arguments:
--logfile " " --radio " " --multi " "
Bug: 15065
Change-Id: I9cd87d9cc8c7e4f8893a066e9f10aa760b52bb97
Reviewed-on: https://code.wireshark.org/review/32887
Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
(cherry picked from commit 727aaad3ae99132470ea0a9eba912aea8ef83ef3)
Reviewed-on: https://code.wireshark.org/review/32891
Petri-Dish: Pascal Quantin <pascal@xxxxxxxxxxxxx>
Reviewed-by: Pascal Quantin <pascal@xxxxxxxxxxxxx>
Actions performed:
from 3fbe882 Release notes: Add a note about Qt 5.12.3.
add 2a9e0e2 Qt: Do not turn empty parameter values into spaces
Summary of changes:
ui/qt/extcap_options_dialog.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
