Wireshark · Wireshark-commits: [Wireshark-commits] master 727aaad: Qt: Do not turn empty parameter values into spaces

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=727aaad3ae99132470ea0a9eba912aea8ef83ef3
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

727aaad by Tomasz Moń (desowin@xxxxxxxxx):

    Qt: Do not turn empty parameter values into spaces
    
    Before this change extcap parameters without value would be silently
    changed into a single space on parameters load.
    This could lead to not only passing unexpected values to extcap call
    arguments but also "auto-fill" text values without user consent.
    
    Example scenario to observe this problem using extcap_example.py was:
      1. Open "Example interface 1 for extcap" configuration
      2. Click Restore Defaults
      3. Enter message, so the capture can be started
      4. Make sure "Save parameter on capture start" is enabled
      5. Start capture
      6. Notice that capture starts normally and extcap arguments are ok
      7. Stop capture
      8. Start capture again
      9. Notice that parameters were reloaded and the extcap was called with
         following unwanted arguments:
           --logfile " " --radio " " --multi " "
    
    Bug: 15065
    Change-Id: I9cd87d9cc8c7e4f8893a066e9f10aa760b52bb97
    Reviewed-on: https://code.wireshark.org/review/32887
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  66b3a33   ENIP: Add more Ethernet Link attributes
     add  727aaad   Qt: Do not turn empty parameter values into spaces


Summary of changes:
 ui/qt/extcap_options_dialog.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)