Wireshark-commits: [Wireshark-commits] master-3.0 7ad4f33: TCP: Adding sequence number only once to
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 16 Mar 2019 08:14:26 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7ad4f339cf4332a8251baf3f6945cae5111507f5
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

7ad4f33 by Uli Heilmeier (uh@xxxxxxxxxxxx):

    TCP: Adding sequence number only once to the tree
    
    When the TCP layer is encapsulated in an icmp error message we're
    adding the sequence number early.
    With this commit we don't add the sequence number a second time.
    
    Bug: 15533
    Change-Id: Iaf983acc15a18fdb36d7baa14f8116e46418160a
    Reviewed-on: https://code.wireshark.org/review/32413
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 12ee180cd41af794320c96a312486d9cf9b21cd6)
    Reviewed-on: https://code.wireshark.org/review/32423
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  4238520   Fix up the checks in nspm_signature_version().
     add  7ad4f33   TCP: Adding sequence number only once to the tree


Summary of changes:
 epan/dissectors/packet-tcp.c | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)