Wireshark · Wireshark-commits: [Wireshark-commits] master-2.4 842d333: Fix up the checks in nspm_signature_version().

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=842d333ea6473de48b1584f5bf01887340274f55
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.4
Repository: wireshark

Commits:

842d333 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix up the checks in nspm_signature_version().
    
    Move the read out of nspm_signature_version(), to make it a bit clearer
    what file I/O we do in the open process; have nspm_signature_version()
    just look for a signature in a single page.
    
    In the loop in nspm_signature_version(), make sure we have enough of the
    record header to look at the type and length fields in that header
    before looking at them and, when we can look at them, make sure the
    length of the record 1) fits in what remains of the page we're looking
    at and 2) is big enough to be the length of a signature record.
    
    Change-Id: I7d625859136e6f39c40b166067fc7efea806d9b0
    Reviewed-on: https://code.wireshark.org/review/32426
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit c0839e2e2ae347483ad96e8b86ddfe8f2ab95bc0)
    Reviewed-on: https://code.wireshark.org/review/32431
    

Actions performed:

    from  2fbbde7   netscaler: add more sanity checks.
     add  842d333   Fix up the checks in nspm_signature_version().


Summary of changes:
 wiretap/netscaler.c | 129 +++++++++++++++++++++++++++++++++++++---------------
 1 file changed, 93 insertions(+), 36 deletions(-)