Wireshark · Wireshark-commits: [Wireshark-commits] master-3.0 262d898: maxmind_db: improve debug messages, harden against bad input

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=262d898e0454db62d584cf890fc8d2b367727b2a
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

262d898 by Peter Wu (peter@xxxxxxxxxxxxx):

    maxmind_db: improve debug messages, harden against bad input
    
    Ensure that country, city, etc. are reset when processing new responses.
    Otherwise if the new response lacks a City, then it would use the result
    of the last query. Harden against bad addresses and print debug messages
    if a bad address is detected.
    
    Miscellaneous cleanups: improve debug messages (strip whitespace
    earlier, etc.), use g_string_assign when possible.
    
    Change-Id: I2acad5fcc02c5a8bf684e8fb01ee2d688d926990
    Reviewed-on: https://code.wireshark.org/review/31950
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 426107f2b5708033e428364151b834be1dc66903)
    Reviewed-on: https://code.wireshark.org/review/31969
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  6c2c3dd   maxmind_db: fix broken GeoIP lookups due to bad address processing
     add  262d898   maxmind_db: improve debug messages, harden against bad input


Summary of changes:
 epan/maxmind_db.c | 45 +++++++++++++++++++++++++++------------------
 1 file changed, 27 insertions(+), 18 deletions(-)