Wireshark-commits: [Wireshark-commits] master-3.0 6c2c3dd: maxmind_db: fix broken GeoIP lookups due
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6c2c3dd3c29d46c983a82305bb139f03f283a43c
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark
Commits:
6c2c3dd by Peter Wu (peter@xxxxxxxxxxxxx):
maxmind_db: fix broken GeoIP lookups due to bad address processing
The "current address" must remain valid until the end of response is
processed, otherwise a bogus entry will be inserted. Move "cur_addr"
outside the block to avoid undefined behavior.
Change-Id: Icc2c64280ffeabd632b51d36d6be2020eb83a6a9
Fixes: v2.9.1rc0-125-g2d9a6c2583 ("maxmind_db: force buffer contain an empty string (CID: 1441961).")
Reviewed-on: https://code.wireshark.org/review/31949
Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
(cherry picked from commit 43692360c47dd16d1d03b785c3779b4835a1ff2b)
Reviewed-on: https://code.wireshark.org/review/31968
Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
Actions performed:
from 681787b json_dumper: add json_dumper_value_double
add 6c2c3dd maxmind_db: fix broken GeoIP lookups due to bad address processing
Summary of changes:
epan/maxmind_db.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)