Wireshark · Wireshark-commits: [Wireshark-commits] master-2.4 4059f48: wslua: do not load console.lua when run as root

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4059f4893294da5e6a799629fd4787287df28b44
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-2.4
Repository: wireshark

Commits:

4059f48 by Peter Wu (peter@xxxxxxxxxxxxx):

    wslua: do not load console.lua when run as root
    
    dofile is currently disabled whenever Wireshark or tshark was started as
    root, calling it will result in Lua errors on startup.
    
    Even if dofile were not disabled, the Lua Evaluate menu option enables
    arbitrary Lua code execution. The other options (Console, help links)
    are not that important either, so just disable it when run as root.
    
    Change-Id: I0785fe9b3d4678d71ae1e0178811dada471c3525
    Link: https://www.wireshark.org/lists/wireshark-dev/201902/msg00004.html
    Reviewed-on: https://code.wireshark.org/review/31912
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit 10ef8b717cb95929d81e4015515dc87fc8c8fc48)
    Bug: 15489
    Reviewed-on: https://code.wireshark.org/review/31928
    

Actions performed:

    from  3fd1868   dnp3: Update Read Objects list
     add  4059f48   wslua: do not load console.lua when run as root


Summary of changes:
 epan/wslua/template-init.lua | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)