Wireshark · Wireshark-commits: [Wireshark-commits] master-2.6 a8b2527: wslua: do not load console.lua when run as root

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a8b25274f198220b6e3928976ac2dd3b0a50dedb
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

a8b2527 by Peter Wu (peter@xxxxxxxxxxxxx):

    wslua: do not load console.lua when run as root
    
    dofile is currently disabled whenever Wireshark or tshark was started as
    root, calling it will result in Lua errors on startup.
    
    Even if dofile were not disabled, the Lua Evaluate menu option enables
    arbitrary Lua code execution. The other options (Console, help links)
    are not that important either, so just disable it when run as root.
    
    Change-Id: I0785fe9b3d4678d71ae1e0178811dada471c3525
    Link: https://www.wireshark.org/lists/wireshark-dev/201902/msg00004.html
    Reviewed-on: https://code.wireshark.org/review/31912
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit 10ef8b717cb95929d81e4015515dc87fc8c8fc48)
    Bug: 15489
    Reviewed-on: https://code.wireshark.org/review/31927
    

Actions performed:

    from  b10de7b   GTP: fix dissection of GGSN addresses in PDP Context ie
     add  a8b2527   wslua: do not load console.lua when run as root


Summary of changes:
 epan/wslua/template-init.lua | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)