Wireshark-commits: [Wireshark-commits] master-3.0 314cce7: wslua: do not load console.lua when run
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 07 Feb 2019 10:29:28 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=314cce735c1843086090880eb6262e42c87f241d
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

314cce7 by Peter Wu (peter@xxxxxxxxxxxxx):

    wslua: do not load console.lua when run as root
    
    dofile is currently disabled whenever Wireshark or tshark was started as
    root, calling it will result in Lua errors on startup.
    
    Even if dofile were not disabled, the Lua Evaluate menu option enables
    arbitrary Lua code execution. The other options (Console, help links)
    are not that important either, so just disable it when run as root.
    
    Change-Id: I0785fe9b3d4678d71ae1e0178811dada471c3525
    Link: https://www.wireshark.org/lists/wireshark-dev/201902/msg00004.html
    Reviewed-on: https://code.wireshark.org/review/31912
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit b3a9667792d0bfe260d4c489d89b607868f51cbe)
    Reviewed-on: https://code.wireshark.org/review/31923
    

Actions performed:

    from  59aca29   debian: fix wrong version in symbols.
     add  314cce7   wslua: do not load console.lua when run as root


Summary of changes:
 epan/wslua/template-init.lua | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)