Wireshark-commits: [Wireshark-commits] master 10ef8b7: wslua: do not load console.lua when run as r
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 07 Feb 2019 10:29:07 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=10ef8b717cb95929d81e4015515dc87fc8c8fc48
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

10ef8b7 by Peter Wu (peter@xxxxxxxxxxxxx):

    wslua: do not load console.lua when run as root
    
    dofile is currently disabled whenever Wireshark or tshark was started as
    root, calling it will result in Lua errors on startup.
    
    Even if dofile were not disabled, the Lua Evaluate menu option enables
    arbitrary Lua code execution. The other options (Console, help links)
    are not that important either, so just disable it when run as root.
    
    Change-Id: I0785fe9b3d4678d71ae1e0178811dada471c3525
    Link: https://www.wireshark.org/lists/wireshark-dev/201902/msg00004.html
    Reviewed-on: https://code.wireshark.org/review/31912
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  b54c9b6   Qt: move packet list cache from record to model
     add  10ef8b7   wslua: do not load console.lua when run as root


Summary of changes:
 epan/wslua/template-init.lua | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)