Wireshark · Wireshark-commits: [Wireshark-commits] master-3.0 8e8072f: editcap: warn when --inject-secrets is given a RSA private k

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8e8072f6ca9a73760f4a067b3a4b805913dfc5ae
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

8e8072f by Peter Wu (peter@xxxxxxxxxxxxx):

    editcap: warn when --inject-secrets is given a RSA private key
    
    While the documentation of "editcap --inject-secrets" mentions support
    for key log files only, people might misinterpret that and assume
    support for RSA private keys. This is explicitly not supported due to
    the sensitivity of these files. In order to be helpful, print a warning.
    
    Change-Id: Ia7b464c17f1dfb550729dd35775290ed28e14510
    Reviewed-on: https://code.wireshark.org/review/31893
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit c6d44eec677e4e28e02a3d132c8b56524fc2aba5)
    Reviewed-on: https://code.wireshark.org/review/31898
    

Actions performed:

    from  9099b9c   CMake: Fix build without LibXml2
     add  8e8072f   editcap: warn when --inject-secrets is given a RSA private key


Summary of changes:
 editcap.c                 | 21 +++++++++++++++++++++
 test/suite_fileformats.py | 20 ++++++++++++++++++++
 2 files changed, 41 insertions(+)