Wireshark-commits: [Wireshark-commits] master 53b55bf: editcap: warn when --inject-secrets is given
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 05 Feb 2019 15:36:48 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=53b55bfb5f775dad6c434bb5b18e260d79b0104d
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

53b55bf by Peter Wu (peter@xxxxxxxxxxxxx):

    editcap: warn when --inject-secrets is given a RSA private key
    
    While the documentation of "editcap --inject-secrets" mentions support
    for key log files only, people might misinterpret that and assume
    support for RSA private keys. This is explicitly not supported due to
    the sensitivity of these files. In order to be helpful, print a warning.
    
    Change-Id: Ia7b464c17f1dfb550729dd35775290ed28e14510
    Reviewed-on: https://code.wireshark.org/review/31893
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  af3c611   CMake: Fix build without LibXml2
     add  53b55bf   editcap: warn when --inject-secrets is given a RSA private key


Summary of changes:
 editcap.c                 | 21 +++++++++++++++++++++
 test/suite_fileformats.py | 20 ++++++++++++++++++++
 2 files changed, 41 insertions(+)