Wireshark-commits: [Wireshark-commits] master b3bb4aa: Have win32strerror() return interned strings
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 01 Feb 2019 20:35:13 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b3bb4aa8f4ee948041442f2e35fb0a4aa3d28667
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

b3bb4aa by Guy Harris (guy@xxxxxxxxxxxx):

    Have win32strerror() return interned strings.
    
    That's what g_strerror() does, and it means that the caller doesn't need
    to free the string (it's kept around, and if another call to
    win32strerror() generates the same string, the interned string is
    returned).
    
    Change-Id: I564bb700fabe2629131fb1c6468494dd5f5fc9e3
    Reviewed-on: https://code.wireshark.org/review/31854
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  961d8bf   pcomtcp: dissection of additional PCOM/ASCII fields
     add  b3bb4aa   Have win32strerror() return interned strings.


Summary of changes:
 capchild/capture_sync.c | 30 ++++++++++--------------------
 wsutil/win32-utils.c    | 37 ++++++++++++++++++-------------------
 wsutil/win32-utils.h    |  2 +-
 3 files changed, 29 insertions(+), 40 deletions(-)