Wireshark-commits: [Wireshark-commits] master 961d8bf: pcomtcp: dissection of additional PCOM/ASCII
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 01 Feb 2019 15:42:51 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=961d8bfc5d37edf5f3361f4cf0f4e251175de1fc
Submitter: "Pascal Quantin <pascal.quantin@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

961d8bf by Luis Rosa (lmrosa@xxxxxxxxx):

    pcomtcp: dissection of additional PCOM/ASCII fields
    
    PCOM/ASCII command codes translation to meaningful descriptions.
    Additional dissect of PCOM/ASCII fields used in read and write
    operations. Some pcap files for testing here [0].
    
    [0] https://github.com/lmrosa/pcom-misc/tree/master/pcaps
    
    Change-Id: I006de518d3de41c6a4b66eb2387cb546054c955d
    Reviewed-on: https://code.wireshark.org/review/31467
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  21565b9   opa-mad: Fixed when ClassDataDetails is zero length
     add  961d8bf   pcomtcp: dissection of additional PCOM/ASCII fields


Summary of changes:
 epan/dissectors/packet-pcomtcp.c | 236 +++++++++++++++++++++++++++++++++++----
 1 file changed, 215 insertions(+), 21 deletions(-)