Wireshark-commits: [Wireshark-commits] master 6cab8c5: funnel: Fix memleaks in funnel_remove_menu
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 28 Jan 2019 10:57:36 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6cab8c57bd0174ffbba203d456d8b10bd3fa02a5
Submitter: "Stig Bjørlykke <stig@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

6cab8c5 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    funnel: Fix memleaks in funnel_remove_menu
    
    The loop to remove all matching callbacks was skipping every second
    entry which would give some leaks when reloading Lua plugins.
    
    Add funnel_cleanup() to be called in epan_cleanup() at shutdown
    to remove all allocated menu entries.
    
    Change-Id: I3a50ba2070c8675fee1385f25e9e109db57c2dc5
    Reviewed-on: https://code.wireshark.org/review/31769
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  5b22624   rpc: don't set fence on COL_PROTOCOL.
     add  6cab8c5   funnel: Fix memleaks in funnel_remove_menu


Summary of changes:
 debian/libwireshark0.symbols | 1 +
 epan/epan.c                  | 1 +
 epan/funnel.c                | 7 ++++++-
 epan/funnel.h                | 1 +
 4 files changed, 9 insertions(+), 1 deletion(-)