Wireshark-commits: [Wireshark-commits] master 5b22624: rpc: don't set fence on COL_PROTOCOL.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 28 Jan 2019 09:33:03 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5b226240c6586b10dccf4ec573f9732097bebcd6
Submitter: "Dario Lombardo <lomato@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

5b22624 by Dario Lombardo (lomato@xxxxxxxxx):

    rpc: don't set fence on COL_PROTOCOL.
    
    That would prevent subsequent protocols to clear it, resulting in multiple
    definitions in that column.
    
    An example is NFS as next protocol. When contains multiple NFS operations,
    COL_PROTOCOL contains NFSNFSNFS...
    
    Bug: 15443
    Change-Id: Idf9469873164160dc4795589c61c342ce019521b
    Reviewed-on: https://code.wireshark.org/review/31755
    Reviewed-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
    

Actions performed:

    from  4dbb26f   GBCS: Increment offset before subtracting length
     add  5b22624   rpc: don't set fence on COL_PROTOCOL.


Summary of changes:
 epan/dissectors/packet-rpc.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)