Wireshark-commits: [Wireshark-commits] master 1527177: TCP: pass data after a ZeroWindowProbe to su
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 27 Jan 2019 09:48:00 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1527177cb97071e78b186d70e89dc83ea7b7cd55
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

1527177 by Peter Wu (peter@xxxxxxxxxxxxx):

    TCP: pass data after a ZeroWindowProbe to subdissectors
    
    If the single byte within a ZeroWindowProbe triggers reassembly within a
    subdissector, a new MSP will be created with just a single byte. Be sure
    not to mark subsequent segments that contain the full segment data as
    retransmission as this prevents the subdissector from seeing the data.
    
    Bug: 15427
    Change-Id: I36ae2622689c6606c99cdff70b6beba4b9d25ca7
    Reviewed-on: https://code.wireshark.org/review/31732
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Jasper Bongertz <jasper@xxxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  596f538   TCP: do not mark data following a ZeroWindowProbe as retransmission
     add  1527177   TCP: pass data after a ZeroWindowProbe to subdissectors


Summary of changes:
 docbook/release-notes.asciidoc |   2 ++
 epan/dissectors/packet-tcp.c   |  23 +++++++++++++++++++++++
 test/captures/retrans-tls.pcap | Bin 0 -> 158 bytes
 test/suite_dissection.py       |  25 +++++++++++++++++++++++++
 4 files changed, 50 insertions(+)
 create mode 100644 test/captures/retrans-tls.pcap