Wireshark-commits: [Wireshark-commits] master 596f538: TCP: do not mark data following a ZeroWindow
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 27 Jan 2019 09:47:51 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=596f538b5bfa2f1b8ec4b3fef839008adb236156
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

596f538 by Peter Wu (peter@xxxxxxxxxxxxx):

    TCP: do not mark data following a ZeroWindowProbe as retransmission
    
    The single byte within the ZWP could be retransmitted with the next
    segment, this is perfectly acceptable behavior. Do not flag these new
    segments as retransmissions or Out-Of-Order.
    
    Bug: 15427
    Change-Id: I76db2b7a2b684c8c78fa24c9c4b457e1833d12b7
    Reviewed-on: https://code.wireshark.org/review/31731
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Jasper Bongertz <jasper@xxxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  089d7a0   doc: update sshdump manual to reflect the current state
     add  596f538   TCP: do not mark data following a ZeroWindowProbe as retransmission


Summary of changes:
 docbook/wsug_src/WSUG_chapter_advanced.asciidoc |  8 ++++++++
 epan/dissectors/packet-tcp.c                    | 11 +++++++++++
 2 files changed, 19 insertions(+)