Wireshark-commits: [Wireshark-commits] master 62ffa95: sshdump: leave username, port and interface
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 27 Jan 2019 09:47:02 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=62ffa95707030cce65424317e3b4b39c870aeec5
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

62ffa95 by Peter Wu (peter@xxxxxxxxxxxxx):

    sshdump: leave username, port and interface unset by default
    
    If the username or port number are unspecified, libssh will pick an
    appropriate default (the local username or port 22 respectively).
    Additionally, it will use the ssh config file if possible.
    
    The eth0 interface is not always appropriate. If the -i option is not
    specified, tcpdump will select an appropriate default.
    
    Change-Id: I99d2136ab27d1652bb420f44d16df063030fb9ce
    Reviewed-on: https://code.wireshark.org/review/31752
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  50fb318   tshark: fix minor memleak of the interface description
     add  62ffa95   sshdump: leave username, port and interface unset by default


Summary of changes:
 extcap/sshdump.c | 35 ++++++++++++++++++++---------------
 1 file changed, 20 insertions(+), 15 deletions(-)