Wireshark-commits: [Wireshark-commits] master 50fb318: tshark: fix minor memleak of the interface d
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 27 Jan 2019 09:44:02 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=50fb31802645003a55e1ecee7d03c4152ca92bc1
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

50fb318 by Peter Wu (peter@xxxxxxxxxxxxx):

    tshark: fix minor memleak of the interface description
    
    Capturing with "tshark -i lo" results in capture_opts->descr being set
    to "Loopback" via:
    
        #3 0x55c5f575720c in fill_in_interface_opts_from_ifinfo capture_opts.c:547:33
        #4 0x55c5f5750dc5 in capture_opts_add_iface_opt capture_opts.c:695:9
        #5 0x55c5f574b6bd in capture_opts_add_opt capture_opts.c:843:18
        #6 0x55c5f5785efc in main tshark.c:1087:21
    
    but tshark overwrites it, presumably to offer textual descriptions like
    "Standard input" for "-i -". Fix this memory leak, reported by ASAN for
    three tests from case_tshark_capture that capture from Loopback.
    
    Change-Id: I4f393c4440bde7a621271cca3066bef3d57e250a
    Reviewed-on: https://code.wireshark.org/review/31756
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  e3a9cc6   wslua_pinfo: fix memleaks on setting addresses in Pinfo
     add  50fb318   tshark: fix minor memleak of the interface description


Summary of changes:
 tshark.c | 1 +
 1 file changed, 1 insertion(+)