Wireshark-commits: [Wireshark-commits] master 7f49d0d: udp-nm: Extend and rename to autosar-nm
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 17 Jan 2019 08:11:28 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7f49d0d1bba009bf82b31ad3cf17c5baf218ea4f
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

7f49d0d by Maksim Salau (maksim.salau@xxxxxxxxx):

    udp-nm: Extend and rename to autosar-nm
    
    The UDP-NM dissector is actually AUTOSAR-NM and works over UDP and CAN.
    
    The change also adds parsing of reserved bits of control bit vector and
    the 'NM Coordinator Id' field which was present in revision 3.2 but now
    is deprecated (bits are marked as reserved).
    
    Since not every packet on a CAN bus is an Network Management one,
    parameters were added to filter only packets with specific ids.
    In order to define ids to be dissected one should define a reference id
    and a mask in preferences.
    
    Change-Id: Ica69032b7200c4c3a1f81130ebcea0dd4144cbf2
    Reviewed-on: https://code.wireshark.org/review/31560
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  9f988b6   RTPS: Possible buffer overrun fixed in PID_TYPEOBJECT_LB dissection.
     add  7f49d0d   udp-nm: Extend and rename to autosar-nm


Summary of changes:
 epan/dissectors/CMakeLists.txt                     |   2 +-
 .../{packet-udp-nm.c => packet-autosar-nm.c}       | 268 ++++++++++++++-------
 2 files changed, 187 insertions(+), 83 deletions(-)
 rename epan/dissectors/{packet-udp-nm.c => packet-autosar-nm.c} (56%)