Wireshark-commits: [Wireshark-commits] master 9f988b6: RTPS: Possible buffer overrun fixed in PID_T
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 17 Jan 2019 08:10:21 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9f988b69a4efb7dfa257598e0c0d33959c7fd467
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

9f988b6 by ismaelrti (ismael@xxxxxxx):

    RTPS: Possible buffer overrun fixed in PID_TYPEOBJECT_LB dissection.
    
    In PID_TYPEOBJECT_LB dissection class_id_enum_names char* array has
    been replaced by a string_values so it won't cause any issue if
    the read index value is out of bounds.
    
    Bug: 15405
    Change-Id: I0dc9d8d00024a2fbb03fca7238ab709b91b059aa
    Reviewed-on: https://code.wireshark.org/review/31484
    Petri-Dish: João Valverde <j@xxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  c9df275   IS-IS: support for dissecting IS-IS BIER Info Sub-TLV (RFC 8401)
     add  9f988b6   RTPS: Possible buffer overrun fixed in PID_TYPEOBJECT_LB dissection.


Summary of changes:
 epan/dissectors/packet-rtps.c | 24 +++++++++++-------------
 1 file changed, 11 insertions(+), 13 deletions(-)