Wireshark-commits: [Wireshark-commits] master 7eb3e47: Try to squeeze some bytes out of the frame_d
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 27 Dec 2018 04:34:36 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7eb3e47fa49806ea2cf59f0fa009240fae049a2b Submitter: "Guy Harris <guy@xxxxxxxxxxxx>" Changed: branch: master Repository: wireshark Commits: 7eb3e47 by Guy Harris (guy@xxxxxxxxxxxx): Try to squeeze some bytes out of the frame_data structure. Make the time stamp precision a 4-bit bitfield, so, when combined with the other bitfields, we have 32 bits. That means we put the flags at the same structure level as the time stamp precision, so they can be combined; that gets rid of an extra "flags." for references to the flags. Put the two pointers next to each other, and after a multiple of 8 bytes worth of other fields, so that there's no padding before or between them. It's still not down to 64 bytes, which is the next lower power of 2, so there's more work to do. Change-Id: I6f3e9d9f6f48137bbee8f100c152d2c42adb8fbe Reviewed-on: https://code.wireshark.org/review/31213 Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx> Actions performed: from c3a7986 Don't allocate per-frame data if we don't have an F5 trailer. add 7eb3e47 Try to squeeze some bytes out of the frame_data structure. Summary of changes: epan/column-utils.c | 24 +++---- .../asn1/ansi_map/packet-ansi_map-template.c | 2 +- .../asn1/ansi_tcap/packet-ansi_tcap-template.c | 2 +- epan/dissectors/asn1/h225/h225.cnf | 2 +- epan/dissectors/asn1/h245/h245.cnf | 4 +- .../asn1/kerberos/packet-kerberos-template.c | 4 +- epan/dissectors/asn1/ldap/ldap.cnf | 4 +- epan/dissectors/asn1/lte-rrc/lte-rrc.cnf | 2 +- epan/dissectors/asn1/ranap/ranap.cnf | 4 +- .../asn1/spnego/packet-spnego-template.c | 2 +- epan/dissectors/asn1/t38/packet-t38-template.c | 4 +- epan/dissectors/file-file.c | 10 +-- epan/dissectors/packet-9p.c | 26 +++---- epan/dissectors/packet-acr122.c | 4 +- epan/dissectors/packet-adb.c | 10 +-- epan/dissectors/packet-adb_cs.c | 6 +- epan/dissectors/packet-adb_service.c | 12 ++-- epan/dissectors/packet-adwin.c | 2 +- epan/dissectors/packet-afs.c | 2 +- epan/dissectors/packet-ansi_map.c | 2 +- epan/dissectors/packet-ansi_tcap.c | 2 +- epan/dissectors/packet-aoe.c | 2 +- epan/dissectors/packet-arp.c | 2 +- epan/dissectors/packet-bluetooth.c | 2 +- epan/dissectors/packet-brdwlk.c | 2 +- epan/dissectors/packet-btatt.c | 34 ++++----- epan/dissectors/packet-btavctp.c | 6 +- epan/dissectors/packet-btavdtp.c | 28 ++++---- epan/dissectors/packet-btavrcp.c | 14 ++-- epan/dissectors/packet-bthci_acl.c | 10 +-- epan/dissectors/packet-bthci_cmd.c | 30 ++++---- epan/dissectors/packet-bthci_evt.c | 34 ++++----- epan/dissectors/packet-bthci_vendor.c | 2 +- epan/dissectors/packet-bthfp.c | 2 +- epan/dissectors/packet-bthsp.c | 4 +- epan/dissectors/packet-btl2cap.c | 16 ++--- epan/dissectors/packet-btle.c | 20 +++--- epan/dissectors/packet-btrfcomm.c | 2 +- epan/dissectors/packet-btsdp.c | 36 +++++----- epan/dissectors/packet-ceph.c | 4 +- epan/dissectors/packet-cip.c | 6 +- epan/dissectors/packet-cipsafety.c | 4 +- epan/dissectors/packet-classicstun.c | 2 +- epan/dissectors/packet-cops.c | 4 +- epan/dissectors/packet-cp2179.c | 2 +- epan/dissectors/packet-cql.c | 2 +- epan/dissectors/packet-ctdb.c | 6 +- epan/dissectors/packet-dcerpc-nt.c | 10 +-- epan/dissectors/packet-dcerpc-spoolss.c | 34 ++++----- epan/dissectors/packet-dcerpc-svcctl.c | 8 +-- epan/dissectors/packet-dcerpc.c | 24 +++---- epan/dissectors/packet-diameter.c | 2 +- epan/dissectors/packet-dji-uav.c | 2 +- epan/dissectors/packet-dmp.c | 6 +- epan/dissectors/packet-dnp.c | 2 +- epan/dissectors/packet-dns.c | 2 +- epan/dissectors/packet-dof.c | 2 +- epan/dissectors/packet-dplay.c | 2 +- epan/dissectors/packet-dtls.c | 2 +- epan/dissectors/packet-eap.c | 6 +- epan/dissectors/packet-enip.c | 8 +-- epan/dissectors/packet-epmd.c | 2 +- epan/dissectors/packet-fc.c | 6 +- epan/dissectors/packet-fcp.c | 8 +-- epan/dissectors/packet-frame.c | 12 ++-- epan/dissectors/packet-ftp.c | 18 ++--- epan/dissectors/packet-geonw.c | 2 +- epan/dissectors/packet-giop.c | 16 ++--- epan/dissectors/packet-gsm_a_bssmap.c | 2 +- epan/dissectors/packet-gssapi.c | 8 +-- epan/dissectors/packet-gvcp.c | 10 +-- epan/dissectors/packet-h225.c | 2 +- epan/dissectors/packet-h245.c | 4 +- epan/dissectors/packet-hartip.c | 2 +- epan/dissectors/packet-hci_mon.c | 2 +- epan/dissectors/packet-hci_usb.c | 2 +- epan/dissectors/packet-iax2.c | 8 +-- epan/dissectors/packet-ieee80211-radio.c | 6 +- epan/dissectors/packet-ieee80211.c | 4 +- epan/dissectors/packet-ieee802154.c | 4 +- epan/dissectors/packet-imap.c | 2 +- epan/dissectors/packet-infiniband.c | 4 +- epan/dissectors/packet-ipsec.c | 2 +- epan/dissectors/packet-ipx.c | 2 +- epan/dissectors/packet-isakmp.c | 4 +- epan/dissectors/packet-iscsi.c | 4 +- epan/dissectors/packet-iso15765.c | 8 +-- epan/dissectors/packet-kerberos.c | 4 +- epan/dissectors/packet-lbmc.c | 2 +- epan/dissectors/packet-lbmpdm.c | 2 +- epan/dissectors/packet-lbtrm.c | 2 +- epan/dissectors/packet-lbtru.c | 4 +- epan/dissectors/packet-ldap.c | 4 +- epan/dissectors/packet-lte-rrc.c | 2 +- epan/dissectors/packet-mbtcp.c | 2 +- ... 118 lines suppressed ...
- Prev by Date: [Wireshark-commits] master c3a7986: Don't allocate per-frame data if we don't have an F5 trailer.
- Next by Date: [Wireshark-commits] master 5278244: test: add comment to fixture.
- Previous by thread: [Wireshark-commits] master c3a7986: Don't allocate per-frame data if we don't have an F5 trailer.
- Next by thread: [Wireshark-commits] master 5278244: test: add comment to fixture.
- Index(es):