Wireshark-commits: [Wireshark-commits] master c3a7986: Don't allocate per-frame data if we don't ha
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c3a7986b86f5355e6bd1791f70b78c91bcdac247
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
c3a7986 by Guy Harris (guy@xxxxxxxxxxxx):
Don't allocate per-frame data if we don't have an F5 trailer.
The F5 trailer dissector is called before the taps are called, so there
is no reason why the taps should attach information to the frame if
there isn't any information attached - if there's an F5 trailer, there
will be information attached to the frame, so there's no need to attach
one, and if there's no F5 trailer, there's no analysis to be done, so
there's no need to attach one.
That way, we don't waste memory that we aren't going to use (about 100MB
for a large capture I have that has almost 3 million packets).
Change-Id: I471b6c9b0fc6eb36f3aff35d6fba2f73c3a0eb90
Ping-Bug: 15385
Reviewed-on: https://code.wireshark.org/review/31210
Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
Actions performed:
from 52d22b2 gcsna: fix no previous prototype for function 'proto_[register|reg_handoff]_gcsna' [-Wmissing-prototypes]
add c3a7986 Don't allocate per-frame data if we don't have an F5 trailer.
Summary of changes:
epan/dissectors/packet-f5ethtrailer.c | 45 +++++++++++++++--------------------
1 file changed, 19 insertions(+), 26 deletions(-)
