Wireshark · Wireshark-commits: [Wireshark-commits] master ad21e31: CMake: disable -Wmissing-field-initializers for broken compilers

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ad21e3121f3307ee6cc2b4a2b296ef6dd83152ed
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

ad21e31 by Peter Wu (peter@xxxxxxxxxxxxx):

    CMake: disable -Wmissing-field-initializers for broken compilers
    
    AppleClang 9.1.0.9020039 is complaining about a "missing initializer" in
    dumpcap.c. Rather than doing ugly things like one of the following:
    
        struct s x;
        memset(&x, 0, sizeof(x));
        struct s y = {.field=0};
    
    just disable the warning (enabled via -Wextra) on broken compilers. The
    minimum versions were determined using https://gcc.godbolt.org/
    
    The special "universal zero initializer { 0 }" exception is explicitly
    documented in the GCC manual (as shipped with GCC 8.2.1). Clang 6 does
    not document it, but r314499 (as included with Clang 6) does implement
    it and adds tests for it. (Xcode 10.0 seems based on Clang 6.0.1.)
    
    Change-Id: I8e48d8c424a512ca36ef8c4f832ce81b3675232c
    Reviewed-on: https://code.wireshark.org/review/30684
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  22db1f0   androiddump: Don't present the verbose config option
     add  ad21e31   CMake: disable -Wmissing-field-initializers for broken compilers


Summary of changes:
 CMakeLists.txt | 12 ++++++++++++
 1 file changed, 12 insertions(+)