Wireshark · Wireshark-commits: [Wireshark-commits] master 22db1f0: androiddump: Don't present the verbose config option

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=22db1f066fb38de335d77372986363e829229ac4
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

22db1f0 by Mikael Kanstrup (mikael.kanstrup@xxxxxxxx):

    androiddump: Don't present the verbose config option
    
    The verbose config option has been replaced by an extcap base debug
    option. Presenting verbose as an available option makes Wireshark
    trying to retrieve the value of this option. As the option is not
    really supported and invalid options after a recent change now
    generate errors the androiddump tool does not start properly.
    
    For reference the problem happens due the unfortunate combo of
    these two patches:
    v2.3.0rc0-1108-gb83ea46 ("extcap: put missed parameters into the help")
    v2.9.0rc0-2431-g945d441 ("extcap: fix return value in extcap_base_parse_options().")
    
    Fix by removing verbose as an available config option.
    
    Change-Id: I894f599708a7160f50ca9ee1f9586022342705cb
    Reviewed-on: https://code.wireshark.org/review/30716
    Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  51fb508   androiddump: Add packets with same encap type as used when open wtap
     add  22db1f0   androiddump: Don't present the verbose config option


Summary of changes:
 extcap/androiddump.c | 4 ----
 1 file changed, 4 deletions(-)