Wireshark-commits: [Wireshark-commits] master 9f74af2: lemon: fix GCC/Clang warnings pre CMake 3.11
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 21 Oct 2018 11:46:46 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9f74af24f1c7e37b1dfce9041a71cc2ac2ed89f9
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

9f74af2 by Peter Wu (peter@xxxxxxxxxxxxx):

    lemon: fix GCC/Clang warnings pre CMake 3.11, silence VSCA warnings
    
    The COMPILE_OPTIONS source file property was introduced with CMake 3.11,
    disable warnings via a target property instead (available since 2.8.12).
    
    Disable some VS Code Analysis warnings. These flags seem to be accepted
    since VS2015, so they can be added unconditionally.
    
    Change-Id: Idfbf154caf8c1168f1f871a640a25b816a2cfab8
    Fixes: v2.9.0rc0-2274-g7ce9081fdc ("lemon: sync with upstream (2018-09-08)")
    Reviewed-on: https://code.wireshark.org/review/30298
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  95614f2   tap-follow: fix memory leak
     add  9f74af2   lemon: fix GCC/Clang warnings pre CMake 3.11, silence VSCA warnings


Summary of changes:
 tools/lemon/CMakeLists.txt | 25 ++++++++++++++++++-------
 1 file changed, 18 insertions(+), 7 deletions(-)