Wireshark-commits: [Wireshark-commits] master 95614f2: tap-follow: fix memory leak
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 21 Oct 2018 11:37:55 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=95614f219f4af7160423dfca8a8b316964d64c3b
Submitter: "Michael Mann <mmann78@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

95614f2 by Vasil Velichkov (vvvelichkov@xxxxxxxxx):

    tap-follow: fix memory leak
    
    Register the follow_free as a finish callback.
    
    Call the tap's finish callback in free_tap_listener which is called from
    both remove_tap_listener and tap_cleanup.
    
    Describe the finish callback in README.tapping
    
    Change-Id: Ie79ce8f39b0ca6d84810d2e3307dcff38b18d3ac
    Reviewed-on: https://code.wireshark.org/review/29309
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  d9b3c05   Supporting Zebra API version 6 used in FRRouting version 6
     add  95614f2   tap-follow: fix memory leak


Summary of changes:
 doc/README.tapping  | 14 +++++++++-----
 epan/tap.c          | 11 +++++++++--
 ui/cli/tap-follow.c |  2 +-
 3 files changed, 19 insertions(+), 8 deletions(-)