Wireshark-commits: [Wireshark-commits] master-2.6 aab39d1: Use ws_basetostru32(), rather than strto
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 19 Oct 2018 20:31:14 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=aab39d19486542027f1d95d02564df728db77621
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

aab39d1 by Guy Harris (guy@xxxxxxxxxxxx):

    Use ws_basetostru32(), rather than strtoul(), when parsing ranges.
    
    Make ws_basetostru32(), and the other ws_baseto... routines, public, and
    use ws_basetostru32() when parsing ranges, to detect additional errors
    such as negative values.
    
    Addresses part of
    https://ask.wireshark.org/question/5538/preference-range/.
    
    Change-Id: I00fac97a198a237b01b5cd9406ea32c220f80972
    Reviewed-on: https://code.wireshark.org/review/30266
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit aed0292c19650446794da07fe5a66f91d79bcaf0)
    Reviewed-on: https://code.wireshark.org/review/30267
    

Actions performed:

    from  9e1f86a   zbee-zcl: register several ett variables.
     add  aab39d1   Use ws_basetostru32(), rather than strtoul(), when parsing ranges.


Summary of changes:
 epan/range.c    | 16 +++++++++-------
 wsutil/strtoi.c |  4 ++--
 wsutil/strtoi.h | 22 ++++++++++++++++++++++
 3 files changed, 33 insertions(+), 9 deletions(-)