Wireshark-commits: [Wireshark-commits] master 5e019c6: Use ws_basetostru32(), rather than strtoul()
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 19 Oct 2018 20:30:59 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5e019c6b8fd01c1d0fe432ad99401612b87c5a36
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

5e019c6 by Guy Harris (guy@xxxxxxxxxxxx):

    Use ws_basetostru32(), rather than strtoul(), when parsing ranges.
    
    Make ws_basetostru32(), and the other ws_baseto... routines, public, and
    use ws_basetostru32() when parsing ranges, to detect additional errors
    such as negative values.
    
    Addresses part of
    https://ask.wireshark.org/question/5538/preference-range/.
    
    Change-Id: I00fac97a198a237b01b5cd9406ea32c220f80972
    Reviewed-on: https://code.wireshark.org/review/30266
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  075ef80   pfcp: register a couple ett variables.
     add  5e019c6   Use ws_basetostru32(), rather than strtoul(), when parsing ranges.


Summary of changes:
 epan/range.c    | 16 +++++++++-------
 wsutil/strtoi.c |  4 ++--
 wsutil/strtoi.h | 22 ++++++++++++++++++++++
 3 files changed, 33 insertions(+), 9 deletions(-)