Wireshark-commits: [Wireshark-commits] master c826e2a: extcap: Close stdout_fd and stderr_fd when d
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 17 Oct 2018 17:46:27 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c826e2a77e21a6f010073956bc0103997584b881
Submitter: "Stig Bjørlykke <stig@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

c826e2a by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    extcap: Close stdout_fd and stderr_fd when done
    
    The documentation for g_spawn_async_with_pipes() states that stdout_fd
    and stderr_fd must be closed when they are no longer in use.
    
    Ping-Bug: 15205
    Change-Id: I943eaa68058b0828686469672ea3611e67390b2f
    Reviewed-on: https://code.wireshark.org/review/30221
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  ca50195   validate-diameter-xml.sh: do not hard-code temporary directory
     add  c826e2a   extcap: Close stdout_fd and stderr_fd when done


Summary of changes:
 extcap.c | 10 ++++++++++
 1 file changed, 10 insertions(+)