Wireshark-commits: [Wireshark-commits] master ca50195: validate-diameter-xml.sh: do not hard-code t
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 17 Oct 2018 15:02:48 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ca50195f1148b855c9fd788725dba77aa4b08315
Submitter: "Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

ca50195 by Peter Wu (peter@xxxxxxxxxxxxx):

    validate-diameter-xml.sh: do not hard-code temporary directory
    
    In the event that validation fails, the hard-coded temporary directory
    would remain present. Use of a fixed hard-coded directory also prevents
    concurrent runs.
    
    Change-Id: I29f09dc004b1ab3578b4a9c51ea7e1a5b526159f
    Reviewed-on: https://code.wireshark.org/review/30231
    Reviewed-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    

Actions performed:

    from  3d6bf1f   Revert "cmake: fix version check for c-ares and gnuTLS"
     add  ca50195   validate-diameter-xml.sh: do not hard-code temporary directory


Summary of changes:
 tools/validate-diameter-xml.sh | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)