Wireshark-commits: [Wireshark-commits] master-2.6 6e920dd: steam-ihs: fix memleak on exception
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 10 Oct 2018 08:43:18 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6e920ddc3cad2886ef07ca1a8e50e2a5c50986f7
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

6e920dd by Peter Wu (peter@xxxxxxxxxxxxx):

    steam-ihs: fix memleak on exception
    
    When protobuf_dissect_unknown_field throws an exception,
    steamdiscover_dissect_body_status will leak memory as
    wmem_destroy_allocator is not called. Capture fuzz-2018-10-06-3104.pcap
    from the linked bug leaks 64kiB memory in each frame 14 and 36.
    
    Bug: 15171
    Change-Id: I930d0738fde61799ab4ef2310f8ff11c1bcb032b
    Fixes: v2.5.1rc0-130-g7ae954c7ac ("steam-ihs: Add dissector for the Steam IHS Discovery Protocol")
    Reviewed-on: https://code.wireshark.org/review/30098
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit f3986c24728f03a346a10388fd6c15ea9ae16d41)
    Reviewed-on: https://code.wireshark.org/review/30108
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  73fd53f   Fix Windows dumpcap -i TCP@
     add  6e920dd   steam-ihs: fix memleak on exception


Summary of changes:
 epan/dissectors/packet-steam-ihs-discovery.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)