Wireshark-commits: [Wireshark-commits] master 03bf0e2: QUIC: fix UAF crash related to the Info colu
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 10 Oct 2018 04:58:39 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=03bf0e23062d481f396b0fc4d96697c9a449dc5a
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

03bf0e2 by Peter Wu (peter@xxxxxxxxxxxxx):

    QUIC: fix UAF crash related to the Info column for Long Header messages
    
    Packet 2478 in capture 15142 triggers a UAF crash since val_to_str is
    packet-scoped and by the time tshark reads the column, it is destroyed.
    
    Bug: 15142
    Change-Id: If8df858c6a295fbac57c758577fb51b288e7f44a
    Reviewed-on: https://code.wireshark.org/review/30104
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  5a2aafe   coap: ensure that piv_len matches piv
     add  03bf0e2   QUIC: fix UAF crash related to the Info column for Long Header messages


Summary of changes:
 epan/dissectors/packet-quic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)