Wireshark-commits: [Wireshark-commits] master 8766166: skinny: remove comment that matches field la
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 20 Sep 2018 22:59:38 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=87661668555720c992d7cd6df13a576069244bbe
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

8766166 by Peter Wu (peter@xxxxxxxxxxxxx):

    skinny: remove comment that matches field label (callState)
    
    Fixes checkAPIs error:
    
        Error: the blurb for hf_skinny_callState ("CallState") matches the
        field name ("callState") in epan/dissectors/packet-skinny.c
    
    Change-Id: Id12396eb101bf66e148aed95d5c773b90d06ff34
    Fixes: v1.99.0-rc1-1511-g276a697a6b ("[RFC] Skinny: Rewrite using automatic code generation")
    Reviewed-on: https://code.wireshark.org/review/29747
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  f3296cd   proto.h: add type checks for VALS/VALS64/VALS_EXT_PTR/TFS/RVALS
     add  8766166   skinny: remove comment that matches field label (callState)


Summary of changes:
 epan/dissectors/packet-skinny.c   | 2 +-
 tools/SkinnyProtocolOptimized.xml | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)