Wireshark-commits: [Wireshark-commits] master f3296cd: proto.h: add type checks for VALS/VALS64/VAL
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 20 Sep 2018 21:00:04 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f3296cdbb66bef47c553e000df8e60ad45b68a5a
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

f3296cd by Peter Wu (peter@xxxxxxxxxxxxx):

    proto.h: add type checks for VALS/VALS64/VALS_EXT_PTR/TFS/RVALS
    
    These macros were evil as they silently ignored bad casts. Together with
    an updated checkAPIs.pl, this should reduce the likelihood of errors.
    
    Change-Id: I40ecc48a57b2061b4c65db4f4f7fffff21f159a8
    Reviewed-on: https://code.wireshark.org/review/29757
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  e3423b1   FP: Show E-DCH entity in tree
     add  f3296cd   proto.h: add type checks for VALS/VALS64/VALS_EXT_PTR/TFS/RVALS


Summary of changes:
 epan/proto.h | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)