Wireshark-commits: [Wireshark-commits] master 71c7798: epan: fix various misannotations of VALS/RVA
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 20 Sep 2018 05:06:13 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=71c7798f8ae40e90a211a74cde8d90cc31bdeaa8
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

71c7798 by Peter Wu (peter@xxxxxxxxxxxxx):

    epan: fix various misannotations of VALS/RVALS/VALS64/TFS
    
    No functional change, just using the correct macro for value_strings.
    Other fixes: Taking the address of the first element of an array gives
    the same address as the array itself. An array of a structure with a
    single element is the same as the single element itself (packet-sprt.c).
    
    Change-Id: I08bc9de49fbd1659a6700ace863e5f05144c7b3e
    Reviewed-on: https://code.wireshark.org/review/29752
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  081c723   simple: fix value_string type mismatch with simple.link16.rc
     add  71c7798   epan: fix various misannotations of VALS/RVALS/VALS64/TFS


Summary of changes:
 epan/dissectors/packet-docsis-tlv.c |  2 +-
 epan/dissectors/packet-gadu-gadu.c  | 18 +++++++++---------
 epan/dissectors/packet-isakmp.c     | 14 +++++++-------
 epan/dissectors/packet-mq.c         | 18 +++++++++---------
 epan/dissectors/packet-sprt.c       |  4 ++--
 epan/wslua/wslua_proto_field.c      |  4 ++--
 6 files changed, 30 insertions(+), 30 deletions(-)