Wireshark-commits: [Wireshark-commits] master 081c723: simple: fix value_string type mismatch with
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 20 Sep 2018 05:05:02 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=081c72344cc39274f496ebc2eefd879db1e93c26
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

081c723 by Peter Wu (peter@xxxxxxxxxxxxx):

    simple: fix value_string type mismatch with simple.link16.rc
    
    Due to alignment, mapping a range_string as value_string happens to work
    on 64-bit systems. On 32-bit systems it will treat it as an empty list.
    In either case, this type confusion is undesired, fix accordingly.
    
    Change-Id: I6f1a249caf822acae2628e7f2df492bab6cc1c5c
    Fixes: v2.1.0rc0-1726-geeae61bc93 ("packet-simple: SIMPLE dissector")
    Reviewed-on: https://code.wireshark.org/review/29751
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  e8c6735   ospf: avoid BASE_EXT_STRING without strings
     add  081c723   simple: fix value_string type mismatch with simple.link16.rc


Summary of changes:
 epan/dissectors/packet-simple.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)